if (0 != count), we already exited the function if (0 != count) { if (pErr) *pErr = NS_ERROR_XPC_NOT_ENOUGH_CHARS_IN_STRING; return false; } The rest is dead code

Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp https://reviewboard.mozilla.org/r/161938/#review167292 Not super-familiar with this code. It looks like the code was inadvertently made dead in bug 677788. I would r+, but maybe there's a secret bug lurking in here somewhere? OTOH, given that we've had this behavior for six years, maybe nothing really relies on it? I'd feel a little better if somebody who knew things about xpconnect gave this a once-over; I'll redirect the review. ::: js/xpconnect/src/XPCConvert.cpp:1757 (Diff revision 1) > if (0 != count) { > len = (count + 1) * sizeof(char16_t); > if (!(*((void**)d) = moz_xmalloc(len))) > return false; > return true; > } > This code is also likewise dead, isn't it?

Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp Blake reviewed bug 677788, so maybe he knows something about this code?

Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp https://reviewboard.mozilla.org/r/161938/#review167542 This looks right to me.

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8816877de730 Remove dead code in XPCConvert.cpp r=mrbkap

Sylvestre, did you see comment 2 (last paragraph)?

https://hg.mozilla.org/integration/mozilla-inbound/rev/816e61957699d19eb96dfccd014ca0487337f065 Bug 1384848 - Remove dead code in XPCConvert.cpp r=mrbkap

done, sorry